Hi Jakub, Thank you for pointing this out, I'm sorry! Can I create a patch to correct the changelog entries?
Best Regards, Sebastian >>1) there should be a space between * and the filename The spaces are there (see the changelog), the renesas mail server removes them sometimes > -----Original Message----- > From: Jakub Jelinek [mailto:ja...@redhat.com] > Sent: 09 February 2018 18:24 > To: Sebastian Perta <sebastian.pe...@renesas.com>; Nick Clifton > <ni...@redhat.com> > Cc: gcc-patches <gcc-patches@gcc.gnu.org> > Subject: Re: PING [PATCH] RX movsicc degrade fix > > On Wed, Feb 07, 2018 at 02:10:21PM +0000, Nick Clifton wrote: > > Hi Sebastian, > > > > Sorry for missing this one. If it helps in the future, feel free to ping me > directly. > > > > > +2018-01-09 Sebastian Perta <sebastian.pe...@renesas.com> > > > + > > > + *config/rx.md: updated "movsicc" expand to be matched by GCC > > > + *testsuite/gcc.target/rx/movsicc.c: new test case > > > > Approved - please apply. > > Note the ChangeLog is incorrect: > 1) there should be a space between * and the filename > 2) testsuite/ has its own ChangeLog, so changes for testsuite/ should > go there and filenames be relative to the testsuite/ directory > 3) there is no config/rx.md file, you've changed config/rx/rx.md instead > 4) the format is * filename (what): Description. , so it should be > * config/rx/rx.md (movsicc): Update expander to be matched by > GCC. > 5) note capital letter after : and full stop at the end. > * gcc.target/rx/movsicc.c: New test. > goes into testsuite/ChangeLog > > Many other of your ChangeLog entries suffer from similar issues. > > Jakub
