From: Eric Botcazou <ebotca...@adacore.com> Date: Tue, 11 Oct 2011 23:08:50 +0200
>> Cool, Eric could you quickly test the following? This still leaves >> the i386.exp case issue open, it stands to reason that something like >> -Wall is needed for those tests too. > > I think that we should go the i386 way. This works on i386 because the > builtins are always available (when you pass the right options) and the > assembler rejects the unknown instructions. So in config/sparc/sparc.h: ... > we shouldn't force TARGET_FMAF and TARGET_VIS3 to 0. The configure test > would > only be used to compute default options. I see, so we can test the code generation in the testsuite even if the compiler was built against an assembler without support for the instructions. But in such a case, I'm unsure if I understand why i386.exp needs these tests at all. The presence of support for a particular i386 intrinsic is an implicit property of the gcc sources that these test cases are a part of. If the tests are properly added only once the code to support the i386 intrinsic is added as well, the checks seem superfluous. Maybe I'm missing something obvious.