> On Apr 6, 2017, at 9:19 AM, Bill Schmidt <wschm...@linux.vnet.ibm.com> wrote:
> 
> 
>> On Apr 6, 2017, at 9:04 AM, Richard Biener <richard.guent...@gmail.com> 
>> wrote:
>> 
>> On Thu, Apr 6, 2017 at 1:28 PM, Nathan Sidwell <nat...@acm.org> wrote:
>>> Let's try this one then.
> 
> Nathan's patch regstraps cleanly.  I'll try Richard's variant (dropping the 
> if test below) now.

FYI, the test case should also include:

// { dg-require-effective-target powerpc_altivec_ok } 

to avoid problems on targets without AltiVec support.

Bill
> 
> Bill
>> 
>> I'd call this
>> 
>> +  if (result == TYPE_CANONICAL (result))
>> +    /* Copy so we don't give the canonical type a name.  */
>> +    result = build_variant_type_copy (result);
>> 
>> premature optimization -- I wonder if anything breaks if you always copy?
>> (that is, I expect result is always the canonical type here?)
>> 
>> Richard.
>> 
>>> nathan
>>> 
>>> --
>>> Nathan Sidwell
>> 
> 

Reply via email to