On Fri, Mar 04, 2016 at 06:12:09PM +0100, Martin Jambor wrote:
> > For the g*.dg/gomp/, if you'd only move -Wno-hsa into the last argument
> > next to -fopenmp, how many tests would be affected?
>
> Out of 287 files that have dg-options with them in the gomp
> directories, only 9 generate hsa warnings:
>
> c-c++-common/gomp/clauses-1.c:/* { dg-options "-fopenmp" } */
> c-c++-common/gomp/if-1.c:/* { dg-options "-fopenmp" } */
> c-c++-common/gomp/pr61486-2.c:/* { dg-options "-fopenmp" } */
> c-c++-common/gomp/target-teams-1.c:/* { dg-options "-fopenmp
> -fdump-tree-gimple" } */
> g++.dg/gomp/target-teams-1.C:// { dg-options "-fopenmp -fdump-tree-gimple" }
> gcc.dg/gomp/pr68128-2.c:/* { dg-options "-O2 -fopenmp -fdump-tree-omplower"
> } */
> gfortran.dg/gomp/target1.f90:! { dg-options "-fopenmp" }
> gfortran.dg/gomp/target2.f90:! { dg-options "-fopenmp
> -ffree-line-length-160" }
> gfortran.dg/gomp/target3.f90:! { dg-options "-fopenmp" }
>
> > If not really many,
> > perhaps those could be changed to use dg-additional-options instead of
> > dg-options.
>
> I do not know what -ffree-line-length-160 is, but probably all of
> them, even though putting -O2 in gcc.dg/gomp/pr68128-2.c to
> "additional" flags feels just wrong.
{ dg-options "-fopenmp" }
can go, that should be the default.
And, I'm fine with moving the -fdump-tree-*, -O2 and -ffree-line-length-160
to dg-additional-options.
I think I prefer it that way.
Jakub
