On Sat, Mar 14, 2015 at 10:51:28AM -0700, Mike Stump wrote:
> On Mar 14, 2015, at 6:58 AM, Bernhard Reutner-Fischer <[email protected]>
> wrote:
> > On March 14, 2015 2:02:38 PM GMT+01:00, Alan Modra <[email protected]> wrote:
> >
> >> I'll also throw together a testcase or three. For execute tests I'm
> >> thinking of using sbrk to locate an odd sized struct such that access
> >> past the end segfaults, rather than mmap/munmap as was done in the
> >> pr36043 testcase. Does that sound reasonable?
> >
> > Well since sbrk was marked LEGACY in SUSv2 and was removed in SUSv3 (and
> > still is in 1003.1-2008) I'm not sure it is wise to use it in new code..
> > Using it will bite testing on legacy-free setups, fwiw.
>
> newlib doesn’t have mmap. Indeed, some machines will never have mmap.
> newlib has sbrk.
Still, I think it is preferrable to test with mmap...
Jakub
