> > Thanks for your interest in this old project. I'm delighted that this > code can be of some use. >
Glad to see this open source release. Thanks! > On 7/1/2022 6:30 PM, Jim Hall wrote: > > This is excellent news! It's great that he has released this under the > > GNU GPL. I did a quick review, and I think these are the only issues I > > found: On Sat, Jul 2, 2022 at 1:07 PM Bob Smith <[email protected]> wrote: > Keep in mind that this source code came from a purely commercial > environment as is, which I then dumped on you folks. The file header > comments were intended for the old context, not the new one. I assumed that was the case. :-) That's why I referred to it as "cleanup" in my other email. > > Issue 1. Bob needs to take the extra step to review his comments in > > his code, to make sure this doesn't conflict with the GNU GPL. For > > example, I did a little poking around and found source files like > > this: > > https://github.com/sudleyplace/386MAX/blob/main/386MAX/LOADALL.INC > > > > At the top of that file, we have: > > > > ;' $Header: P:/PVCS/MAX/386MAX/LOADALL.INV 1.0 11 Aug 1995 10:56:06 HENRY $ > > ; > > ; (C) Copyright 1987-92 Qualitas, Inc. All rights reserved. > > ; > > ; LOADALL.INC > > ; > > ; 286 LOADALL and 386 LOADALL structures > > ; > > > > The "(C) Copyright 1987-92 Qualitas, Inc" is fine. I'd recommend that > > this get updated to "1987-92, 2022" to represent that the code was > > also released in 2022. And it would probably be best for Bob to put > > his name in there somewhere, to indicate he has the rights to release > > this as GNU GPL. (Maybe Bob would be willing to copy/paste his comment > > from https://github.com/sudleyplace/DPMIONE/issues/3#issuecomment-1172710414 > > into a README file in the GitHub project? That would probably get to > > the same place.) But as it is, that should be okay. (IANAL) > > > > But the "All rights reserved" is a problem. This is incompatible with > > the GNU GPL. At best, it is confusing. But this really needs to get > > cleaned up before we can include it in FreeDOS. (Note we had the same > > "All rights reserved" issue with FDNET's Crynwr network drivers a > > while ago. That issue was resolved when Russel later confirmed the > > extra "All rights reserved" statements were added by an automated > > process.[*1]) > > On a per-file basis, I would be happy with the "All rights reserved" > statement removed, but I would like to see the Copyright statement > remain, changing "Qualitas, Inc." to "Sudley Place Software", along with > an optional GPL v3 statement included, or just a "See LICENSE file." or > equivalent wording. > To be clear, the copyright statement is okay. I should have been more clear on this: I meant to suggest that you have your name in the copyright statement as well, or some other statement to indicate you are the copyright holder (because only the copyright holder can choose to release something as open source software). Having your name (or Sudley Place Software .. that's your option) removes possible confusion later on. > As it took a long long time to upload these files, I'm hoping you all > know of a quicker way to make mass changes. Perhaps there is a GUI > interface for this. As I'd like to stay out of the maintenance of this > project, I'd be happy to give some of you write access to the repository > in order to accomplish the above changes. My desktop system is Linux, so I can suggest the "Linux way" to do this. You can change any instance of "All rights reserved" to "GNU General Public License version 3" in all files in a directory called "386max" by starting with this 3-line shell script: (save this as changetext.bash) #!/bin/bash cp "$1" /tmp/tempfile sed -e 's/All rights reserved/GNU General Public License version 3/g' /tmp/tempfile > "$1" ..and then you run this command: $ find 386max -type f -name '*.INC' -exec bash changetext.bash {} \; What that does: The "changetext.bash" script is just a quick way to batch up two commands: make a copy of the file (I used quotes so variable expansion would preserve spaces) then use sed to change the text from the copy, and overwrite the original file. (The "#!" line is technically not needed here, because the "find" command calls it with "bash" anyway.) The "find" command starts at the "386max" directory, and for every *.INC file that it finds, it executes the command "bash changetext.bash {}" where "{}" gets replaced by the filename. You will need to re-run this for any plain text file (like TXT or DOC or SRC or ..) that has the string you want to change. After you run each "find" command, you can check what other files have the string with this command: $ find 386max -type f -exec fgrep -q 'All rights reserved' {} \; -print I hope that helps! Jim _______________________________________________ Freedos-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/freedos-devel
