On Fri, Jul 1, 2022 at 5:30 PM Jim Hall <[email protected]> wrote: > > This is excellent news! It's great that he has released this under the > GNU GPL. I did a quick review, and I think these are the only issues I > found: > > > Issue 1. Bob needs to take the extra step to review his comments in > his code, to make sure this doesn't conflict with the GNU GPL. For > example, I did a little poking around and found source files like > this: > https://github.com/sudleyplace/386MAX/blob/main/386MAX/LOADALL.INC > > At the top of that file, we have: > > ;' $Header: P:/PVCS/MAX/386MAX/LOADALL.INV 1.0 11 Aug 1995 10:56:06 HENRY $ > ; > ; (C) Copyright 1987-92 Qualitas, Inc. All rights reserved. > ; > ; LOADALL.INC > ; > ; 286 LOADALL and 386 LOADALL structures > ; > [..]
By the way, this issue also exists on the other projects Bob has released on GitHub. For example, this file in DPMIONE also has the "All rights reserved" comment: https://github.com/sudleyplace/DPMIONE/blob/master/GXT_COM.INC ..but the License file says this is GNU GPL v3: https://github.com/sudleyplace/DPMIONE/blob/master/LICENSE This is code cleanup. I think you or Bob can locate all the strings by searching for "All rights reserved" in the code. You can automate that. If you do this on a Linux system or somewhere with good command line tools, you could also automate replacing "All rights reserved" with something like "GNU General Public License version 3, see the file LICENSE for details." * The GNU GPL says it is safest to attach a long comment at the start of every code file with some GNU GPL boilerplate text, but my reading of the GNU GPL is that this boilerplate is "best practices" but not required. So I think having "GNU General Public License version 3, see the file LICENSE for details" or possibly just "GNU General Public License version 3" would be enough. (IANAL) Jim _______________________________________________ Freedos-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/freedos-devel
