Thanks for your interest in this old project. I'm delighted that this
code can be of some use.
On 7/1/2022 6:30 PM, Jim Hall wrote:
This is excellent news! It's great that he has released this under the
GNU GPL. I did a quick review, and I think these are the only issues I
found:
Keep in mind that this source code came from a purely commercial
environment as is, which I then dumped on you folks. The file header
comments were intended for the old context, not the new one.
Issue 1. Bob needs to take the extra step to review his comments in
his code, to make sure this doesn't conflict with the GNU GPL. For
example, I did a little poking around and found source files like
this:
https://github.com/sudleyplace/386MAX/blob/main/386MAX/LOADALL.INC
At the top of that file, we have:
;' $Header: P:/PVCS/MAX/386MAX/LOADALL.INV 1.0 11 Aug 1995 10:56:06 HENRY $
;
; (C) Copyright 1987-92 Qualitas, Inc. All rights reserved.
;
; LOADALL.INC
;
; 286 LOADALL and 386 LOADALL structures
;
The "(C) Copyright 1987-92 Qualitas, Inc" is fine. I'd recommend that
this get updated to "1987-92, 2022" to represent that the code was
also released in 2022. And it would probably be best for Bob to put
his name in there somewhere, to indicate he has the rights to release
this as GNU GPL. (Maybe Bob would be willing to copy/paste his comment
from https://github.com/sudleyplace/DPMIONE/issues/3#issuecomment-1172710414
into a README file in the GitHub project? That would probably get to
the same place.) But as it is, that should be okay. (IANAL)
But the "All rights reserved" is a problem. This is incompatible with
the GNU GPL. At best, it is confusing. But this really needs to get
cleaned up before we can include it in FreeDOS. (Note we had the same
"All rights reserved" issue with FDNET's Crynwr network drivers a
while ago. That issue was resolved when Russel later confirmed the
extra "All rights reserved" statements were added by an automated
process.[*1])
On a per-file basis, I would be happy with the "All rights reserved"
statement removed, but I would like to see the Copyright statement
remain, changing "Qualitas, Inc." to "Sudley Place Software", along with
an optional GPL v3 statement included, or just a "See LICENSE file." or
equivalent wording.
As it took a long long time to upload these files, I'm hoping you all
know of a quicker way to make mass changes. Perhaps there is a GUI
interface for this. As I'd like to stay out of the maintenance of this
project, I'd be happy to give some of you write access to the repository
in order to accomplish the above changes.
Issue 2. Bob should also review his GitHub project to ensure that
every binary file included there has source code for it somewhere. For
example, https://github.com/sudleyplace/386MAX/tree/main/CYADISK seems
to be nothing but DLL and EXE files. I think the source is in
https://github.com/sudleyplace/386MAX/tree/main/CYASETUP but I'm not
sure.
In general, if there's no source code for something, Bob should
consider removing that from the tree.
While I haven't tried to compile it, the source code for CYA looks to be
in the CYASETUP directory.
I think those are the only issues I found in doing a quick review of
Bob's GitHub project. In the meantime, I'll post a news item about it
on the website and tweet about it from our Twitter account.
--
_______________________________________________________________
Bob Smith - [email protected]
http://www.sudleyplace.com - http://www.nars2000.org
_______________________________________________
Freedos-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/freedos-devel
