* Pav Lucistnik ([email protected]) wrote:
> > second
> > also improves MAKE_JOBS_* handling, shortening it a bit and exposing
> > MAKE_JOBS_NUMBER to the ports, so it can be used for other build systems
> > without having to parse out -j from _MAKE_JOBS (and defaults to 1 if
> > jobs support is disabled).
>
> This one I cannot accept, because it adds back != call I made a big
> effort to avoid. We can't have one != call per port during building
> INDEX.
Understood. I still think it'd be nice to expose number of jobs as a
plain number to the ports.
> > Also, [ x != x${BUILD_FAIL_MESSAGE} ] thing seems to be a bit unsafe,
> > and inconsistent to IGNORE/BROKEN/... vars, in which we don't use
> > quotes.
>
> It's consistent with CONFIGURE_FAIL_MESSAGE. Why are you removing the
> parenthesis around the ${ECHO_CMD} ${BUILD_FAIL_MESSAGE}, BTW?
> Because they are present in do-configure target too - should they be
> removed there too?
I just didn't like them :) Are they really needed around single command?
--
Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D
[email protected] ..: jabber: [email protected] http://www.amdmi3.ru
_______________________________________________
[email protected] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "[email protected]"
