Dmitry Marakasov píše v pá 27. 03. 2009 v 04:02 +0300: > * Pav Lucistnik ([email protected]) wrote: > > > > Btw, this change broke build failures. If vendor's make fails, > > > .build_done.xxx._usr_local is still created in work and $? = 0 as if it > > > have succeeded. > > > > Can you give me a hard example? > > Test port consisting of a sole Makefile attached. > > I've made two patches for bsd.port.mk. > First one fixes this issue by adding some false's to do-build,
Ah right, I have stolen do-configure targets and missed the ${FALSE}.
Will fix.
> second
> also improves MAKE_JOBS_* handling, shortening it a bit and exposing
> MAKE_JOBS_NUMBER to the ports, so it can be used for other build systems
> without having to parse out -j from _MAKE_JOBS (and defaults to 1 if
> jobs support is disabled).
This one I cannot accept, because it adds back != call I made a big
effort to avoid. We can't have one != call per port during building
INDEX.
> Also, [ x != x${BUILD_FAIL_MESSAGE} ] thing seems to be a bit unsafe,
> and inconsistent to IGNORE/BROKEN/... vars, in which we don't use
> quotes.
It's consistent with CONFIGURE_FAIL_MESSAGE. Why are you removing the
parenthesis around the ${ECHO_CMD} ${BUILD_FAIL_MESSAGE}, BTW?
Because they are present in do-configure target too - should they be
removed there too?
--
Pav Lucistnik <[email protected]>
<[email protected]>
Pain clots and unformed lice pat this train.
signature.asc
Description: Toto je digitálně podepsaná část zprávy
