Michael Pasternak has posted comments on this change.
Change subject: core,restapi: attach detach storage connections
......................................................................
Patch Set 20:
(4 comments)
....................................................
Commit Message
Line 15: * DetachStorageConnectionFromStorageDomainCommand
Line 16:
Line 17: REST:
Line 18: * Attach:
Line 19: POST /api/storagedomains/{storage_id}
i guess URI should be /api/storagedomains/{storage_id}/storageconnections
Line 20: <storage_connection id="{connection_id}">
Line 21: </storage_connection>
Line 22: * Detach:
Line 23: DELETE
/api/storagedomains/{storage_id}/storageconnections/{connection_id}
Line 20: <storage_connection id="{connection_id}">
Line 21: </storage_connection>
Line 22: * Detach:
Line 23: DELETE
/api/storagedomains/{storage_id}/storageconnections/{connection_id}
Line 24:
any wiki/BZ ?
Line 25: Change-Id: I319bc9f51c81e2df0c7ed3b3338fcd7b4783fe84
Line 26: Signed-off-by: Daniel Erez <de...@redhat.com>
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
Line 1194: request:
Line 1195: body:
Line 1196: parameterType: null
Line 1197: signatures: []
Line 1198: urlparams: {}
please add async [1] param
[1] async: {context: matrix, type: 'xs:boolean', value: true|false, required:
false}
Line 1199: headers: {}
Line 1200: - name:
/api/storagedomains/{storagedomain:id}/storageconnections|rel=add
Line 1201: request:
Line 1202: body:
....................................................
File
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainServerConnectionsResourceTest.java
Line 71: }
Line 72: }
Line 73:
Line 74: @Test
Line 75: public void testDetachSuccess() throws Exception {
format?
Line 76: setUriInfo(setUpBasicUriExpectations());
Line 77: setUpGetEntityExpectations();
Line 78:
setUpActionExpectations(VdcActionType.DetachStorageConnectionFromStorageDomain,
Line 79: AttachDetachStorageConnectionParameters.class,
--
To view, visit http://gerrit.ovirt.org/17864
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I319bc9f51c81e2df0c7ed3b3338fcd7b4783fe84
Gerrit-PatchSet: 20
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Cheryn Tan <cheryn...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
