Allon Mureinik has posted comments on this change.

Change subject: core,restapi: attach detach storage connections
......................................................................


Patch Set 18:

(1 comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageConnectionToStorageDomainCommand.java
Line 98: 
Line 99: @Override
Line 100:     protected Map<String, Pair<String, String>> getExclusiveLocks() {
Line 101:         Map<String, Pair<String, String>> locks = new HashMap<String, 
Pair<String, String>>();
Line 102:         // lock connection's id to avoid  removing this connection at 
the same time
double space between avoid and removing.
Line 103:         // by another user
Line 104:         locks.put(getParameters().getStorageConnectionId(),
Line 105:                 
LockMessagesMatchUtil.makeLockingPair(LockingGroup.STORAGE_CONNECTION,
Line 106:                         
VdcBllMessages.ACTION_TYPE_FAILED_OBJECT_LOCKED));


-- 
To view, visit http://gerrit.ovirt.org/17864
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I319bc9f51c81e2df0c7ed3b3338fcd7b4783fe84
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Cheryn Tan <cheryn...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to