Arik Hadas has posted comments on this change.

Change subject: core: add failCanDoAction method with variable replacements
......................................................................


Patch Set 3:

(1 comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 1941:      * @param variableReplacements variable replacements
Line 1942:      * @return  false always
Line 1943:      * @see {@link #addCanDoActionMessage(String)}
Line 1944:      */
Line 1945:     protected final boolean failCanDoAction(VdcBllMessages message, 
String ... variableReplacements) {
Done (good catch, it was really redundant to have the other method..)
Line 1946:         addCanDoActionMessage(message);
Line 1947:         for (String variableReplacement : variableReplacements) {
Line 1948:             addCanDoActionMessage(variableReplacement);
Line 1949:         }


-- 
To view, visit http://gerrit.ovirt.org/18006
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I57dc350f507db43db2ddd47e835eca67ea96b4ed
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to