Arik Hadas has posted comments on this change.
Change subject: core: add failCanDoAction method with variable replacements
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 1946: addCanDoActionMessage(message);
Line 1947: for (String variableReplacement : variableReplacements) {
Line 1948: addCanDoActionMessage(variableReplacement);
Line 1949: }
Line 1950: return false;
yes, I tried to change addCanDoActionMessage(VdcBllMessages) to delegate to
addCanDoActionMessage(String) with message.name but it caused the AddVdsCommand
tests to fail (there's a simple adjustment in AddVdsCommandTest that solve it).
so in another patch where I'll do it, I'll delegate here as well.
Line 1951: }
Line 1952:
Line 1953: /**
Line 1954: * Add a message to the {@link CommandBase#canDoAction()}'s
return value.
--
To view, visit http://gerrit.ovirt.org/18006
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I57dc350f507db43db2ddd47e835eca67ea96b4ed
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
