Yair Zaslavsky has posted comments on this change.
Change subject: core: add failCanDoAction method with variable replacements
......................................................................
Patch Set 3:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 1941: * @param variableReplacements variable replacements
Line 1942: * @return false always
Line 1943: * @see {@link #addCanDoActionMessage(String)}
Line 1944: */
Line 1945: protected final boolean failCanDoAction(VdcBllMessages message,
String ... variableReplacements) {
No need for two methods.
There should be one method, the one you added, an that's it.
if you do not pass any variable replacement, the length of the String array is
0, no chance for NPE or some ugly stuff like that, and in this case the method
will behave exactly as the original one.
Line 1946: addCanDoActionMessage(message);
Line 1947: for (String variableReplacement : variableReplacements) {
Line 1948: addCanDoActionMessage(variableReplacement);
Line 1949: }
--
To view, visit http://gerrit.ovirt.org/18006
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I57dc350f507db43db2ddd47e835eca67ea96b4ed
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
