Sahina Bose has posted comments on this change.
Change subject: engine: Added taskId to volume and brick
......................................................................
Patch Set 11:
(2 comments)
Yair, thanks for the suggestion regarding view. That got us thinking, so we
will revert the view change as it is not required in every flow. Will add a
separate method to populate task of volume entity
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterBrickEntity.java
Line 1: package org.ovirt.engine.core.common.businessentities.gluster;
Line 2:
Line 3: import javax.validation.constraints.NotNull;
Line 4:
Line 5: import org.ovirt.engine.core.common.asynctasks.gluster.GlusterAsyncTask;
Do you mean instead of GlusterBrickEntity?
Line 6: import org.ovirt.engine.core.common.businessentities.BusinessEntity;
Line 7: import org.ovirt.engine.core.common.businessentities.IVdcQueryable;
Line 8: import org.ovirt.engine.core.common.utils.ObjectUtils;
Line 9: import org.ovirt.engine.core.common.validation.group.CreateEntity;
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeEntity.java
Line 168: public void setStripeCount(Integer stripeCount) {
Line 169: this.stripeCount = stripeCount;
Line 170: }
Line 171:
Line 172: public GlusterAsyncTask getTask() {
Yes. Only Volume and Brick will an asynchronous task associated with it. But we
could implement a GlusterTaskSupport
Line 173: return asyncTask;
Line 174: }
Line 175:
Line 176: public void setTask(GlusterAsyncTask task) {
--
To view, visit http://gerrit.ovirt.org/17992
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82247bac8217a81f52b16092637885a336e455d5
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
