Sahina Bose has posted comments on this change. Change subject: engine: Added taskId to volume and brick ......................................................................
Patch Set 9: (2 comments) You may also want to rename the script file to start with 03_04_ .................................................... File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDao.java Line 72: Line 73: public void updateGlusterVolume(GlusterVolumeEntity volume); Line 74: Line 75: public void updateAsyncTask(Guid volumeId, Guid taskId); Line 76: Can we call this updateVolumeTask so as not to confuse with vdsm async task? .................................................... File packaging/dbscripts/create_views.sql Line 1557: AS Line 1558: SELECT gluster_volumes.*, Line 1559: vds_groups.name AS vds_group_name, Line 1560: step.step_type as async_task_type, Line 1561: step.status as async_task_status Can we call these columns step_type and step_status? Line 1562: FROM gluster_volumes Line 1563: INNER JOIN vds_groups ON gluster_volumes.cluster_id = vds_groups.vds_group_id Line 1564: LEFT OUTER JOIN step ON gluster_volumes.task_id = step.external_id; Line 1565: -- To view, visit http://gerrit.ovirt.org/17992 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82247bac8217a81f52b16092637885a336e455d5 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
