Eli Mesika has posted comments on this change.
Change subject: engine: Added taskId to volume and brick
......................................................................
Patch Set 17:
(3 comments)
....................................................
File packaging/dbscripts/gluster_volumes_sp.sql
Line 236: RETURN QUERY SELECT *
Line 237: FROM step
Line 238: WHERE external_id IS NOT NULL
Line 239: AND external_system_type = 'GLUSTER'
Line 240: AND external_id = (select task_id from gluster_volumes where
id = v_volume_id);
1) How often this is executed
If executed frequently , I would recommend selecting from a view that joins
those tables
2) I would expect adding an index on external_id (in the upgrade script)
Line 241: END; $procedure$
Line 242: LANGUAGE plpgsql;
Line 243:
Line 244: Create or replace FUNCTION
GetTransportTypesByGlusterVolumeGuid(v_volume_id UUID)
....................................................
File packaging/dbscripts/upgrade/03_03_0800_add_taskid_to_volumeandbricks.sql
Line 1: -- adding taskid column to gluster volumes used to store gluster task
id returned
task_id
Line 2: SELECT fn_db_add_column('gluster_volumes', 'task_id', 'uuid');
Line 3:
Line 4: -- adding taskid column to gluster volume bricks used to store gluster
task id returned
Line 5: SELECT fn_db_add_column('gluster_volume_bricks', 'task_id', 'uuid');
Line 1: -- adding taskid column to gluster volumes used to store gluster task
id returned
Line 2: SELECT fn_db_add_column('gluster_volumes', 'task_id', 'uuid');
Line 3:
Line 4: -- adding taskid column to gluster volume bricks used to store gluster
task id returned
task_id
Line 5: SELECT fn_db_add_column('gluster_volume_bricks', 'task_id', 'uuid');
--
To view, visit http://gerrit.ovirt.org/17992
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82247bac8217a81f52b16092637885a336e455d5
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
