Omer Frenkel has posted comments on this change.
Change subject: core: refactorings in RunVmValidtor#canRunVm
......................................................................
Patch Set 9:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java
Line 209: }
Line 210:
Line 211: public ValidationResult validateVdsStatus(VM vm) {
Line 212: if (vm.getStatus() == VMStatus.Paused && vm.getRunOnVds() !=
null) {
Line 213: VDS vds = getVdsDao().get(new
Guid(vm.getRunOnVds().toString()));
maybe not for this patch, but i think this
new Guid(vm.getRunOnVds().toString())
can be changed to this
vm.getRunOnVds()
Line 214: if (vds.getStatus() != VDSStatus.Up) {
Line 215: return new
ValidationResult(VdcBllMessages.ACTION_TYPE_FAILED_VDS_STATUS_ILLEGAL,
Line 216:
VdcBllMessages.VAR__HOST_STATUS__UP.toString());
Line 217: }
--
To view, visit http://gerrit.ovirt.org/17896
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib18c7582a0b1b5686c35259be3aed5d399871a15
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
