Omer Frenkel has submitted this change and it was merged. Change subject: core: refactorings in RunVmValidtor#canRunVm ......................................................................
core: refactorings in RunVmValidtor#canRunVm As a first stage in fixing regressions that were found in RunVmValidator causing HA VMs not to start when there is not SPM defined, this patch refactor the canRunVM method to be more concise and readable: - use RunVmValidator#validate within #canRunVm method to make it shorter and more organized. - changed #validateStorageDomains, #validateImagesForRunVm and #validateVdsStatus methods to return ValidationResult instead of boolean as the other validation methods In addition, validations that were executed only when the VM had images even though they check things which are not related to images were moved such that they will be always executed. Change-Id: Ib18c7582a0b1b5686c35259be3aed5d399871a15 Signed-off-by: Arik Hadas <aha...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java 1 file changed, 38 insertions(+), 80 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17896 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib18c7582a0b1b5686c35259be3aed5d399871a15 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
