Arik Hadas has posted comments on this change. Change subject: core: refactorings in RunVmValidtor#canRunVm ......................................................................
Patch Set 6: I wondered why I didn't need to update the tests.. it seems that the methods I changed didn't have UTs.. the regular excuse developers use is "I don't have the time" right? it's not that I don't have the time, but it will be waste of time to do it in this stage, as I plan to make further changes to this class which will make it stateful and the UTs will then have to be changed as well. so let's add the UTs then, is that ok? -- To view, visit http://gerrit.ovirt.org/17896 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib18c7582a0b1b5686c35259be3aed5d399871a15 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
