Ravi Nori has posted comments on this change. Change subject: engine : Null Pointer Exception for action CreateAllSnapshotsFromVm after failure in create snapshot ......................................................................
Patch Set 7: @Maor I think you might be right. All the logic in CommandAsyncTask assumes that taskGroupSucess has been set to true. In case of failure this flag is set to false. Whill we might overwrite in patch 7 I think we should leave taskGroupSucess to true and provide this patch as in patch set 4. On a global scale when we address this issue we should code in CommandAsyncTask, SPMAsyncTask and the commands. -- To view, visit http://gerrit.ovirt.org/17590 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If89c45a236029078eae4a4254837b373c88adfd2 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
