Greg Sheremeta has posted comments on this change.
Change subject: webadmin: fixed edit name availability in tree context
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
Line 747: hostModel.getCommands().add(command);
Line 748:
Line 749: if (getSystemTreeSelectedItem() != null &&
getSystemTreeSelectedItem().getType() == SystemTreeItemType.Host) {
Line 750: hostModel.getName().setIsChangable(false);
Line 751: hostModel.getName().setInfo("Cannot edit Host's
Name in tree context"); //$NON-NLS-1$
There are many of these setInfo calls. I opened two BZs to 1. change all of
them to be localized, and 2. fix the tooltip not working for all of them.
I'd like to put off your suggestions until I work on those BZs, if that's
alright.
BZs 995754 and 995755
Line 752: }
Line 753:
Line 754: }
Line 755: };
--
To view, visit http://gerrit.ovirt.org/17886
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie50a6fcfeacdc94fe900f6569180106c31f5e9c8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
