Michael Pasternak has posted comments on this change.
Change subject: core, restapi: add GetVmOvfConfigurationQuery
......................................................................
Patch Set 10:
(1 comment)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotsResource.java
Line 127: }
Line 128:
Line 129: @Override
Line 130: protected Snapshot doPopulate(Snapshot model,
org.ovirt.engine.core.common.businessentities.Snapshot entity) {
Line 131: if (isPopulate()) {
reviewing this class, i didn't knew that you call
BackendSnapshotsResource.doPopulate() from the
BackendSnapshotResource.doPopulate(),
so AbstractBackendCollectionResource.mapEntity() does relevant, but
explanation above gives you insight on correctness of this flow, so just drop
if (isPopulate()) condition
thanks
Line 132: VdcQueryReturnValue queryReturnValue =
Line 133:
runQuery(VdcQueryType.GetVmOvfConfigurationBySnapshot,
Line 134: new
IdQueryParameters(Guid.createGuidFromString(model.getId())));
Line 135:
--
To view, visit http://gerrit.ovirt.org/16176
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I46340c4461b57a4c314fb50ca9c19ac5fd08a451
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Deepak C Shetty <deepa...@linux.vnet.ibm.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
