Daniel Erez has posted comments on this change.
Change subject: webadmin: fixed edit name availability in tree context
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
Line 747: hostModel.getCommands().add(command);
Line 748:
Line 749: if (getSystemTreeSelectedItem() != null &&
getSystemTreeSelectedItem().getType() == SystemTreeItemType.Host) {
Line 750: hostModel.getName().setIsChangable(false);
Line 751: hostModel.getName().setInfo("Cannot edit Host's
Name in tree context"); //$NON-NLS-1$
No need, it's non-functional any way. Would be simpler to just remove it
altogether (member/getters/setters). Just don't forget about it...
Line 752: }
Line 753:
Line 754: }
Line 755: };
--
To view, visit http://gerrit.ovirt.org/17886
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie50a6fcfeacdc94fe900f6569180106c31f5e9c8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
