Yaniv Bronhaim has posted comments on this change.
Change subject: core: Fixes logging in SshSoftFencingCommand
......................................................................
Patch Set 6: I would prefer that you didn't submit this
(1 inline comment)
Looks great, but still one last little comment.. Thanks
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SshSoftFencingCommand.java
Line 87: cmdErr);
Line 88: log.infoFormat("SSH Soft Fencing command executed on host
{0}", getVds().getHostName());
Line 89: result = true;
Line 90: } catch (Exception ex) {
Line 91: log.errorFormat("SSH Soft Fencing command failed on host
{0}: {1}\nStdout: {2}\nStderr: {3}\nStacktrace: {4}",
do you really need \n between the prints? isn't it dirt the log?
That's enough:
"SSH Soft Fencing command failed on host {0}, stdOut: {1}, strErr: {2}. Error:
{3}",
getVds().getHostName(), cmdOut.toString(), cmdErr.toString(), ex
Line 92: getVds().getHostName(), ex.getMessage(),
cmdOut.toString(), cmdErr.toString(), ex);
Line 93: } finally {
Line 94: closeSshConnection(sshClient);
Line 95: }
--
To view, visit http://gerrit.ovirt.org/16619
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ea12003bd44f6500e3878176e98debd102da056
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
