Martin Peřina has posted comments on this change. Change subject: core: Fixes logging in SshSoftFencingCommand ......................................................................
Patch Set 3: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SshSoftFencingCommand.java Line 74: sshClient.useDefaultKeyPair(); Line 75: sshClient.connect(); Line 76: sshClient.authenticate(); Line 77: cmdOut = new ByteArrayOutputStream(); Line 78: cmdErr = new ByteArrayOutputStream(); If you look at logCommandOutput, you will notice the not null check. And I can't think of any reason why "splitted try scopes" would produce more detailed log. Line 79: sshClient.executeCommand(Config.<String> GetValue(ConfigValues.SshSoftFencingCommand, version), Line 80: null, Line 81: cmdOut, Line 82: cmdErr); -- To view, visit http://gerrit.ovirt.org/16619 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ea12003bd44f6500e3878176e98debd102da056 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
