Yaniv Bronhaim has posted comments on this change. Change subject: core: Fixes logging in SshSoftFencingCommand ......................................................................
Patch Set 6: Yes, newline in logs is redundant and space consumer, and it doesn't help to read the log. You can use grep to arrange the prints, callstack prints take enough space already. And anyway,the stderr or strout can be null, so you just print empty line. Just asked to consider that, its not common. -- To view, visit http://gerrit.ovirt.org/16619 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ea12003bd44f6500e3878176e98debd102da056 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
