Alex Lourie has posted comments on this change. Change subject: packaging: setup: support OVF import ......................................................................
Patch Set 3: Looks good to me, but someone else must approve (1 inline comment) Minor comment .................................................... File src/plugins/ovirt-hosted-engine-setup/vm/boot_disk.py Line 66: ) Line 67: try: Line 68: tar = tarfile.open(self._tar, 'r:gz') Line 69: src_file_obj = tar.extractfile(self._src) Line 70: dst_file_obj = None twice dst_file_obj? Line 71: dst_file_obj = open(self._dst, 'wb') Line 72: try: Line 73: shutil.copyfileobj(src_file_obj, dst_file_obj) Line 74: dst_file_obj.truncate() -- To view, visit http://gerrit.ovirt.org/17521 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I04b1de72c19e558b20d46e9fe6a435c594b0005d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@gmail.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
