Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: support OVF import
......................................................................
Patch Set 5:
(2 comments)
....................................................
File src/plugins/ovirt-hosted-engine-setup/vm/boot_disk.py
Line 252: )
Line 253: for filename in tar.getnames():
Line 254: self.logger.debug(filename)
Line 255: if (
Line 256: filename.startswith('master') and
why 'master'? Never looked at ovf images, but I seem to find on the net
examples without 'master'. The wikipedia article just says there should be
exactly one file with an '.ovf' extension, nothing about 'master'.
Line 257: os.path.splitext(filename)[1] == '.ovf'
Line 258: ):
Line 259: ovf_xml = filename
Line 260: break
....................................................
File src/plugins/ovirt-hosted-engine-setup/vm/configurevm.py
Line 101: 'from (@VALUES@) [@DEFAULT@]: '
Line 102: ),
Line 103: prompt=True,
Line 104: caseSensitive=True,
Line 105: validValues=self.BOOT_DEVICE.keys(),
you might want to add here too 'list()' for python 3.3
Line 106: default=ohostedcons.Defaults.DEFAULT_BOOT,
Line 107: )
Line 108:
Line 109: if self.environment[
--
To view, visit http://gerrit.ovirt.org/17521
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I04b1de72c19e558b20d46e9fe6a435c594b0005d
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com>
Gerrit-Reviewer: Lev Veyde <lve...@gmail.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
