Sandro Bonazzola has posted comments on this change.
Change subject: packaging: setup: support OVF import
......................................................................
Patch Set 5:
(1 comment)
....................................................
File src/plugins/ovirt-hosted-engine-setup/vm/boot_disk.py
Line 252: )
Line 253: for filename in tar.getnames():
Line 254: self.logger.debug(filename)
Line 255: if (
Line 256: filename.startswith('master') and
> See this one for example:
> http://openvpn.net/index.php/access-server/download-openvpn-as-vm/469-deploying-openvpn-access-server-from-an-ovf-template-in-vmware-esxi-environment.html
Note that the image you're pointing is an OVA not an OVF. Well, it seems that
the right extension for the archive should be ova and only the xml should have
ovf extension. This patch is based on image-uploader code so it has the same
limitations.
> I did not try hosted-engine on this image (and nor image uploader), but it
> seems to me like it will fail in several different places including "master":
> I do not see there Content/Name, but do see VirtualSystem/Name No
> Section/Disk, yes DiskSection/Disk No size, Yes capacity No disk-alias num of
> cpus/sockets is different It has several different AllocationUnits, none is
> MegaBytes
The fields I used are from the 1.0 specification:
http://schemas.dmtf.org/ovf/envelope/1/dsp8023_1.1.0.xsd the only also
supported by image-uploader
DiskSection seems to be in 2.0 specification:
http://schemas.dmtf.org/ovf/envelope/2/dsp8023_2.0.xsd
> Note that in addition to know knowing anything about ovf I know almost
> nothing about xml, and nothing about xsd :-)
> What image did you test it with?
One used by istein for testing image-uploader, so the ovf archive is
image-uploader compliant.
Line 257: os.path.splitext(filename)[1] == '.ovf'
Line 258: ):
Line 259: ovf_xml = filename
Line 260: break
--
To view, visit http://gerrit.ovirt.org/17521
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I04b1de72c19e558b20d46e9fe6a435c594b0005d
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com>
Gerrit-Reviewer: Lev Veyde <lve...@gmail.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
