Allon Mureinik has posted comments on this change.
Change subject: [wip] backend: add glance storage domain support
......................................................................
Patch Set 4: Looks good to me, but someone else must approve
(1 inline comment)
@mpastern - your comments on the rest parts would be appreciated.
@aburden - same goes for the *.properties files.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageType.java
Line 44: return mappings.get(value);
Line 45: }
Line 46:
Line 47: public boolean isFileDomain() {
Line 48: return this == NFS || this == POSIXFS || this == LOCALFS ||
this == GLUSTERFS || this == GLANCE;
Probably a good idea, at least for the operations GLANCE does support (e.g.,
we'd want to create sparse volumes on it).
Perhaps we also need another "isManaged()" property too
Line 49: }
Line 50:
Line 51: public boolean isBlockDomain() {
Line 52: return this == FCP || this == ISCSI;
--
To view, visit http://gerrit.ovirt.org/15897
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3271b3c49907900e37560b63c8ce54d52c463a1e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: A Burden <abur...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
