Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Updated the nfs service name usage
......................................................................
Patch Set 3: (2 inline comments)
....................................................
File ovirt-engine.spec.in
Line 472: install -d "%{buildroot}%{_sysconfdir}/ovirt-engine-setup.conf.d"
Line 473: cat >
"%{buildroot}%{_sysconfdir}/ovirt-engine-setup.conf.d/10-packaging.conf" <<
__EOF__
Line 474: [environment:default]
Line 475: OVESETUP_APACHE/configureRootRedirectionDefault=bool:True
Line 476: OVESETUP_SYSTEM/nfsServiceName=str:'nfs'
but this is the default... :)
Line 477: __EOF__
Line 478: cat >
"%{buildroot}%{_sysconfdir}/ovirt-engine-setup.conf.d/10-packaging-aio.conf" <<
__EOF__
Line 479: [environment:default]
Line 480: OVESETUP_AIO/enable=bool:True
....................................................
File packaging/setup/plugins/ovirt-engine-setup/system/nfs.py
Line 72: self.logger.warning(
Line 73: _('Unsupported distribution disabling nfs export')
Line 74: )
Line 75: self._enabled = False
Line 76: elif self._distribution == 'fedora':
no need... we can use the environment either default or what packaging put.
Line 77: self.environment[
Line 78: osetupcons.SystemEnv.NFS_SERVICE_NAME
Line 79: ] = 'nfs-server'
Line 80:
--
To view, visit http://gerrit.ovirt.org/15954
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I17f4b564517c180e0fe14a0a4ed3d0e0b97a5e19
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
