Alon Bar-Lev has posted comments on this change.

Change subject: packaging: Updated the nfs service name usage
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File packaging/setup/plugins/ovirt-engine-setup/system/nfs.py
Line 75:             self._enabled = False
Line 76:         elif self._distribution == 'fedora':
Line 77:             self.environment[
Line 78:                 osetupcons.SystemEnv.NFS_SERVICE_NAME
Line 79:             ] = 'nfs-server'
set something as default... package will always be able to override this. Look 
for 10-packaging.conf at spec file.
Line 80: 
Line 81:     @plugin.event(
Line 82:         stage=plugin.Stages.STAGE_CUSTOMIZATION,
Line 83:         name=osetupcons.Stages.SYSTEM_NFS_CONFIG_AVAILABLE,


-- 
To view, visit http://gerrit.ovirt.org/15954
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I17f4b564517c180e0fe14a0a4ed3d0e0b97a5e19
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to