Sandro Bonazzola has posted comments on this change.
Change subject: packaging: Updated the nfs service name usage
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File packaging/setup/plugins/ovirt-engine-setup/system/nfs.py
Line 55: osetupcons.SystemEnv.NFS_CONFIG_ENABLED,
Line 56: None
Line 57: )
Line 58: self._enabled = True
Line 59: self._servicename = 'nfs'
I would have used an environment variable for storing the service name, like we
did with HTTPD_SERVICE
Line 60:
Line 61: @plugin.event(
Line 62: stage=plugin.Stages.STAGE_SETUP,
Line 63: )
Line 70: _('Unsupported distribution disabling nfs export')
Line 71: )
Line 72: self._enabled = False
Line 73:
Line 74: if self._distribution == 'fedora':
elif
Line 75: self._servicename = 'nfs-server'
Line 76:
Line 77: @plugin.event(
Line 78: stage=plugin.Stages.STAGE_CUSTOMIZATION,
--
To view, visit http://gerrit.ovirt.org/15954
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I17f4b564517c180e0fe14a0a4ed3d0e0b97a5e19
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
