Yedidyah Bar David has posted comments on this change.
Change subject: config: avoid to change existing configuration files
......................................................................
Patch Set 1: No score
(1 inline comment)
no warning for now
....................................................
File src/__main__.py
Line 323: 'engine',
Line 324: cp.get('LogCollector', 'rhevm')
Line 325: )
Line 326: cp.remove_option('LogCollector', 'rhevm')
Line 327: logging.warning(
I think we should not log a warning for now. just use the old option if it
exists (and the new one doesn't - agree with Alon above). On some later version
change the conf file during the upgrade, then we can log a warning if we still
see it, e.g. because /etc was read-only, restored from a backup/tripwire/etc,
whatever.
Line 328: _(
Line 329: 'The deprecated configuration key rhevm has been
found '
Line 330: 'in configuration files.\n'
Line 331: 'Please update your configuration changing rhevm '
--
To view, visit http://gerrit.ovirt.org/15366
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I55c707424524826235f1faba52c0fafd72a27300
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
