Sandro Bonazzola has posted comments on this change. Change subject: config: avoid to change existing configuration files ......................................................................
Patch Set 3: (1 inline comment) .................................................... File src/__main__.py Line 314: ) Line 315: Line 316: cp = ConfigParser.ConfigParser() Line 317: #backward compatibility with existing setup Line 318: for configfile in configs: So, what should I do with keith's request for expliciting the config file that has the legacy config? Line 319: cp.read(configfile) Line 320: if cp.has_option('LogCollector', 'rhevm'): Line 321: if not cp.has_option('LogCollector', 'engine'): Line 322: cp.set( -- To view, visit http://gerrit.ovirt.org/15366 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I55c707424524826235f1faba52c0fafd72a27300 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Keith Robertson <krobe...@redhat.com> Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches