Yair Zaslavsky has posted comments on this change.
Change subject: gluster: Added queries for service list
......................................................................
Patch Set 24: No score
(1 inline comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/gluster/GlusterServiceQueryParameters.java
Line 10:
Line 11: private ServiceType serviceType;
Line 12:
Line 13: public GlusterServiceQueryParameters(Guid groupId) {
Line 14: super(groupId);
is it ok to have null serviceType in this case?
Line 15: }
Line 16:
Line 17: public GlusterServiceQueryParameters(Guid groupId, ServiceType
serviceType) {
Line 18: super(groupId);
--
To view, visit http://gerrit.ovirt.org/15122
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e027a49a5a5a49ff37ef78433a96b81add3f8d4
Gerrit-PatchSet: 24
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
