Alon Bar-Lev has posted comments on this change.

Change subject: packaging: setup: fixed memory requirements validation
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File packaging/setup/plugins/ovirt-engine-setup/system/memcheck.py
Line 143:                     abort = dialog.queryBoolean(
Line 144:                         dialog=self.dialog,
Line 145:                         name='OVESETUP_MEMORY_CHECK',
Line 146:                         note=_(
Line 147:                             'Do you want to exit the setup? '
Something less generic will be better if we ever do automation...

Something like:

Do you want to install with memory less than recommended?
Line 148:                             '(@VALUES@) [@DEFAULT@]: '
Line 149:                         ),
Line 150:                         prompt=True,
Line 151:                         true=_('Yes'),


--
To view, visit http://gerrit.ovirt.org/14916
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I46e125e418ec0f2951850825dbeca9a5f9eadfbf
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to