Sandro Bonazzola has posted comments on this change.
Change subject: packaging: setup: fixed memory requirements validation
......................................................................
Patch Set 2: (3 inline comments)
....................................................
File packaging/setup/plugins/ovirt-engine-setup/system/memcheck.py
Line 119: if (
Line 120: not interactive and
Line 121: not
self.environment[osetupcons.SystemEnv.MEMCHECK_ENABLED]
Line 122: ):
Line 123: return
Done
Line 124: self.logger.debug('Checking total memory')
Line 125: with open('/proc/meminfo', 'r') as f:
Line 126: content = f.read()
Line 127:
Line 135: if match.group('unit') == "kB":
Line 136: self._total_memory //= 1024
Line 137:
Line 138: satisfied = self._check_requirements()
Line 139: print interactive
removed, left from debugging
Line 140: abort = False
Line 141: if not satisfied:
Line 142: if not interactive:
Line 143: abort =
osetupcons.Defaults.DEFAULT_SYSTEM_MEMCHECK_ENABLED
Line 139: print interactive
Line 140: abort = False
Line 141: if not satisfied:
Line 142: if not interactive:
Line 143: abort =
osetupcons.Defaults.DEFAULT_SYSTEM_MEMCHECK_ENABLED
The required behavior is described in
https://bugzilla.redhat.com/show_bug.cgi?id=928386#c1 I'm not sure I can just
perform the check only in interactive.
Line 144: else:
Line 145: abort = dialog.queryBoolean(
Line 146: dialog=self.dialog,
Line 147: name='OVESETUP_MEMORY_CHECK',
--
To view, visit http://gerrit.ovirt.org/14916
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I46e125e418ec0f2951850825dbeca9a5f9eadfbf
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
