Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: fixed memory requirements validation ......................................................................
Patch Set 2: (1 inline comment) .................................................... File packaging/setup/plugins/ovirt-engine-setup/system/memcheck.py Line 139: print interactive Line 140: abort = False Line 141: if not satisfied: Line 142: if not interactive: Line 143: abort = osetupcons.Defaults.DEFAULT_SYSTEM_MEMCHECK_ENABLED Don't you told that in non interactive we just warn? so we can always check but just warn? Line 144: else: Line 145: abort = dialog.queryBoolean( Line 146: dialog=self.dialog, Line 147: name='OVESETUP_MEMORY_CHECK', -- To view, visit http://gerrit.ovirt.org/14916 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46e125e418ec0f2951850825dbeca9a5f9eadfbf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
