Laszlo Hornyak has posted comments on this change.
Change subject: engine: watchdog - DB and logic changes
......................................................................
Patch Set 15: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
Line 487: addVmNetwork();
Line 488: addVmStatistics();
Line 489: addActiveSnapshot();
Line 490: addVmPermission();
Line 491: addVmWatchdog();
you mean in the one starting with "if (addVmImages()) {..." on line 497?
Line 492: getCompensationContext().stateChanged();
Line 493: return null;
Line 494: }
Line 495: });
Line 493: return null;
Line 494: }
Line 495: });
Line 496:
Line 497: if (addVmImages()) {
this is a funny line because addVmImages always returns true - or Exception is
raised if CreateSnapshotFromTemplate fails. so the if is totally misleading.
Line 498: TransactionSupport.executeInNewTransaction(new
TransactionMethod<Void>() {
Line 499:
Line 500: @Override
Line 501: public Void runInTransaction() {
--
To view, visit http://gerrit.ovirt.org/13057
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I813a6f97e23008d15446285998a4e9b50b456040
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
