Omer Frenkel has posted comments on this change.
Change subject: engine: watchdog - DB and logic changes
......................................................................
Patch Set 15: (1 inline comment)
minor comments inside, thanks for the changes
what is the plan for templates?
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateWatchdogCommand.java
Line 31:
getVmDeviceDao().getVmDeviceByVmIdAndType(getParameters().getVmId(),
VmDeviceType.WATCHDOG.getName());
Line 32: if (watchdogs.isEmpty()) {
Line 33: return failCanDoAction(VdcBllMessages.WATCHDOG_NOT_FOUND);
Line 34: }
Line 35: return super.canDoAction();
you are calling super.canDoAction twice, i guess here it should be return true
Line 36: }
Line 37:
--
To view, visit http://gerrit.ovirt.org/13057
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I813a6f97e23008d15446285998a4e9b50b456040
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
