Omer Frenkel has posted comments on this change. Change subject: engine: watchdog - DB and logic changes ......................................................................
Patch Set 15: (1 inline comment) still reviewing but i think the class AbstractVmWatchdogCommand is missing, please add it .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java Line 487: addVmNetwork(); Line 488: addVmStatistics(); Line 489: addActiveSnapshot(); Line 490: addVmPermission(); Line 491: addVmWatchdog(); because of compensation in this command its better to have this call in the second transaction below, otherwise handling will need to be added in case there is a failure later on Line 492: getCompensationContext().stateChanged(); Line 493: return null; Line 494: } Line 495: }); -- To view, visit http://gerrit.ovirt.org/13057 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I813a6f97e23008d15446285998a4e9b50b456040 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
