Eli Mesika has posted comments on this change.

Change subject: engine:Sync gluster hooks
......................................................................


Patch Set 7: (1 inline comment)

....................................................
File backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
Line 135: 
Line 136: -- Gluster related
Line 137: select fn_db_add_config_value('GlusterHooksEnabled', 'false', '3.0');
Line 138: select fn_db_add_config_value('GlusterHooksEnabled', 'false', '3.1');
Line 139: select fn_db_add_config_value('GlusterHooksEnabled', 'false', '3.2');
Sahina
Its Ok for me
What I don't like is that now we have hybrid config behaviour when some adds 
3.3 entries and some don't
Can you please open a BZ asking for aligning all entries to the decision you 
had got so we I can do that cross config keys and update the DB wiki as well ?

thanks
Line 140: select fn_db_add_config_value('GlusterRefreshHeavyWeight', 'false', 
'3.0');
Line 141: select fn_db_add_config_value('GlusterRefreshHeavyWeight', 'false', 
'3.1');
Line 142: select fn_db_add_config_value('GlusterRefreshRateHooks', '7200', 
'general');
Line 143: select fn_db_add_config_value('GlusterRefreshRateLight', '5', 
'general');


--
To view, visit http://gerrit.ovirt.org/13943
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2766edd4e810677a200cf5c45d334cabef5f2924
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to