Kanagaraj M has posted comments on this change.
Change subject: engine:Sync gluster hooks
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
Line 142: select
fn_db_add_config_value('GlusterVolumeOptionGroupVirtValue','virt','general');
Line 143: select
fn_db_add_config_value('GlusterVolumeOptionOwnerUserVirtValue','36','general');
Line 144: select
fn_db_add_config_value('GlusterVolumeOptionOwnerGroupVirtValue','36','general');
Line 145: select fn_db_add_config_value('GlusterRefreshRateHooks', '600',
'general');
Line 146: select fn_db_add_config_value('GlusterHooksEnabled', 'true', '3.3');
We should be making the feature support entry only for non supported cluster
version.
Something like
select fn_db_add_config_value('GlusterHooksEnabled', 'false', '3.0');
select fn_db_add_config_value('GlusterHooksEnabled', 'false', '3.1');
select fn_db_add_config_value('GlusterHooksEnabled', 'false', '3.2');
and 3.3 taken care in the code by true as default value.
Line 147: select
fn_db_add_config_value('GuestToolsSetupIsoPrefix','RHEV-toolsSetup_','general');
Line 148: select fn_db_add_config_value('HardwareInfoEnabled','false','3.0');
Line 149: select fn_db_add_config_value('HardwareInfoEnabled','false','3.1');
Line 150: select fn_db_add_config_value('HardwareInfoEnabled','true','3.2');
--
To view, visit http://gerrit.ovirt.org/13943
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2766edd4e810677a200cf5c45d334cabef5f2924
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
