Shireesh Anjal has posted comments on this change.
Change subject: engine:Sync gluster hooks
......................................................................
Patch Set 7: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
Line 135:
Line 136: -- Gluster related
Line 137: select fn_db_add_config_value('GlusterHooksEnabled', 'false', '3.0');
Line 138: select fn_db_add_config_value('GlusterHooksEnabled', 'false', '3.1');
Line 139: select fn_db_add_config_value('GlusterHooksEnabled', 'false', '3.2');
Eli, there is no reason to force adding an entry for every version.
There was a discussion around this on the engine-devel mailing list
(http://lists.ovirt.org/pipermail/engine-devel/2013-April/004150.html) as well
as on my patch here:
http://gerrit.ovirt.org/#/c/12970/5/backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
(I'm sorry I missed adding you as a reviewer on that patch, and no one
reminded me either)
Do let us know if you think there is a valid reason for adding entry for every
version.
Line 140: select fn_db_add_config_value('GlusterRefreshHeavyWeight', 'false',
'3.0');
Line 141: select fn_db_add_config_value('GlusterRefreshHeavyWeight', 'false',
'3.1');
Line 142: select fn_db_add_config_value('GlusterRefreshRateHooks', '7200',
'general');
Line 143: select fn_db_add_config_value('GlusterRefreshRateLight', '5',
'general');
--
To view, visit http://gerrit.ovirt.org/13943
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2766edd4e810677a200cf5c45d334cabef5f2924
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
