Liron Ar has posted comments on this change. Change subject: core: inactive domain can be selected as master ......................................................................
Patch Set 6: Verified Verified- just Rebased. Michael, we don't care/want to rely on that possible domain monitoring from the "former connected to pool hsms" that might see itself as connected (although we don't actually have pool right now) - that's what the issue about. we can decide if we want to leave that implementation as was discussed, , which means that all hosts in up can reconstruct to inactive domains or add logic which might or might not work in all cases, as discussed with Ayal before implementing, we don't want to add this logic or rely on it..that might be a vdsm implementation detail that the engine will try to rely on..might differ between vdsm versions, etc - the issue that we have after this patch is a known issue, that the current master can't be selected as master again and it will be changed in different patch as it's pre-existing issue. -- To view, visit http://gerrit.ovirt.org/13160 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9031e2fe0afc161c1a3acdddc9b1e7a58626a159 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches