Liron Ar has posted comments on this change. Change subject: core: inactive domain can be selected as master ......................................................................
Patch Set 5: >> "Always, when all domains in inActive status and all host connected to pool. >> This is standard case of failover and I suppose this a first case that you >> should check in your environment, before sending a patch and putting +1 in >> Verified." Can you please elaborate on the case - you say that we are connected to the pool (to the master domain) but it's inactive? how do we get to that scenario? "Idea is wrong, why? If no Active/Unknown domain in pool, meaning we have not any host that can see it, no reason for reconstruct" - that's exactly the issue, when hosts aren't connected to the pool - we can't recover the domains from being inactive to be active - the behaviour that we want in the system is to attempt to reconstruct to those inactive domains. - >> You read a code ? Connect is send only from spm election or InitVds on up, >> if host is in status Up connect will be send only in case that host is >> selected as SPM, again basics. I didn't quite understand how this is related to my comment, I commented about reconstruct to inactive domains. >> "Your patch should solve all issues, when you writing a patch that opens a >> new issues, which actually a direct result of your patch, because like I >> said your patch is not 100% correct..." The issue of master not being selected for reconstruct is existing issue and should be solved regardless to this patch - i will solve it as well, but in different patch. -- To view, visit http://gerrit.ovirt.org/13160 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9031e2fe0afc161c1a3acdddc9b1e7a58626a159 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
