Alexander Wels has posted comments on this change.

Change subject: userportal, webadmin: branding support[WIP].
......................................................................


Patch Set 4: (2 inline comments)

....................................................
File 
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/branding/BrandingManager.java
Line 55:      * Constructor that takes a {@code File} object to configure the 
brandingRootPath.
Line 56:      * @param etcDir A {@code File} pointing to the branding root path.
Line 57:      */
Line 58:     public BrandingManager(final File etcDir) {
Line 59:         brandingRootPath = new File(etcDir + BRANDING_PATH);
Done
Line 60:     }
Line 61: 
Line 62:     /**
Line 63:      * Get a list of available {@code BrandingTheme}s.


Line 70:             List<File> directories = Arrays.asList(
Line 71:                     brandingRootPath.listFiles(new FileFilter() {
Line 72:                         @Override
Line 73:                         public boolean accept(final File file) {
Line 74:                             return file.isDirectory();
It does, I checked.
Line 75:                         }
Line 76:                     }));
Line 77:             for (File directory : directories) {
Line 78:                 BrandingTheme theme = new BrandingTheme(


--
To view, visit http://gerrit.ovirt.org/13181
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a8a426ce7d688d33c5ae2b70632c836843106b2
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to